lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Oct 2014 15:43:23 -0400 (EDT) From: David Miller <davem@...emloft.net> To: lsorense@...lub.uwaterloo.ca Cc: linux-kernel@...r.kernel.org, hs@...x.de, mugunthanvnm@...com, netdev@...r.kernel.org Subject: Re: Mistake in commit 0d961b3b52f566f823070ce2366511a7f64b928c breaks cpsw non dual_emac mode. From: "Lennart Sorensen" <lsorense@...lub.uwaterloo.ca> Date: Tue, 28 Oct 2014 13:02:42 -0400 > I believe commit 0d961b3b52f566f823070ce2366511a7f64b928c made a mistake > while correcting a bug. This patch submission is not properly formed. You subject line should be of the form: subsystem: Description. "subsystem" here would be "cpsw: " or something like that. Secondly, you should not refer to a commit ID in the patch Subject line, instead just describe exactly what is being fixed in the most succinct yet complete manner that is possible. Thirdly, when you do refer to commit ID's in your commit message body you must do so in the following format: ${SHA1_ID} ("Commit message header line text.") The commit message body is also not a place to have a general discussion. Please avoid saying things like "I think", for example. State facts, and be exact about what the problem is and exactly how you are fixing it. Because this commit message will be read by others looking at your change days, weeks, years from now. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists