netdev - Re: [PATCHv2 1/1] ip-link: add switch to show human readable output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141029224738.263e27bd@urahara>
Date:	Wed, 29 Oct 2014 22:47:38 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Christian Hesse <mail@...rm.de>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCHv2 1/1] ip-link: add switch to show human readable output

On Sat, 11 Oct 2014 00:27:36 +0200
Christian Hesse <mail@...rm.de> wrote:

> Byte and packet count can increase to really big numbers. This adds a
> switch to show human readable output.
> 
> % ip -s link ls wl
> 4: wl: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP mode DORMANT group default qlen 1000
>     link/ether 00:de:ad:be:ee:ef brd ff:ff:ff:ff:ff:ff
>     RX: bytes  packets  errors  dropped overrun mcast
>     113570876  156975   0       0       0       0
>     TX: bytes  packets  errors  dropped carrier collsns
>     27290790   94313    0       0       0       0
> % ip -s -h link ls wl
> 4: wl: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP mode DORMANT group default qlen 1000
>     link/ether 00:de:ad:be:ee:ef brd ff:ff:ff:ff:ff:ff
>     RX: bytes  packets  errors  dropped overrun mcast
>     122368888  169840   0       0       0       0
>     116.7Mi    165.8Ki  0       0       0       0
>     TX: bytes  packets  errors  dropped carrier collsns
>     29087507   102309   0       0       0       0
>     27.7Mi     99.9Ki   0       0       0       0
> ---

I like the idea as a concept but there are two issues:
  1. The IEC suffix is a rarely used thing and is non-standard
     for communications where K = 1000 M = 1000000 etc.
     Please just use standard suffices

  2. Don't double print the data, if the user asks for human
     format, only show the human format.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html