netdev - Re: [PATCH] net: skb_fclone_busy() needs to detect orphaned skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20141030.195947.399658939004489177.davem@davemloft.net>
Date:	Thu, 30 Oct 2014 19:59:47 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, ncardwell@...gle.com
Subject: Re: [PATCH] net: skb_fclone_busy() needs to detect orphaned skb

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 30 Oct 2014 10:32:34 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Some drivers are unable to perform TX completions in a bound time.
> They instead call skb_orphan()
> 
> Problem is skb_fclone_busy() has to detect this case, otherwise
> we block TCP retransmits and can freeze unlucky tcp sessions on
> mostly idle hosts.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Fixes: 1f3279ae0c13 ("tcp: avoid retransmits of TCP packets hanging in host queues")

Applied, and queued up for -stable, thanks Eric.

>  This problem is known to hurt users of linux-3.16 kernels used by guests kernels.
>  David, I can provide backports if you want.

Since 3.16 is no longer active, I'll only need to put this into 3.17-stable
which I should be able to handle on my own.

But thanks for offering, sometimes difficult backports take up a lot
of time.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html