lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20141031035635.GC4082@lunn.ch> Date: Fri, 31 Oct 2014 04:56:35 +0100 From: Andrew Lunn <andrew@...n.ch> To: Guenter Roeck <linux@...ck-us.net> Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Andrew Lunn <andrew@...n.ch>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] net: ethtool: Return -EOPNOTSUPP if user space tries to read EEPROM with lengh 0 On Thu, Oct 30, 2014 at 08:50:15PM -0700, Guenter Roeck wrote: > If a driver supports reading EEPROM but no EEPROM is installed in the system, > the driver's get_eeprom_len function returns 0. ethtool will subsequently > try to read that zero-length EEPROM anyway. If the driver does not support > EEPROM access at all, this operation will return -EOPNOTSUPP. If the driver > does support EEPROM access but no EEPROM is installed, the operation will > return -EINVAL. Return -EOPNOTSUPP in both cases for consistency. > > Signed-off-by: Guenter Roeck <linux@...ck-us.net> root@...665:~# ethtool -e lan4 Cannot get EEPROM data: Operation not supported Tested-by: Andrew Lunn <andrew@...n.ch> Thanks Andrew -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists