lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20141031064105.GA16156@vergenet.net> Date: Fri, 31 Oct 2014 15:41:08 +0900 From: Simon Horman <simon.horman@...ronome.com> To: Pravin B Shelar <pshelar@...ira.com> Cc: davem@...emloft.net, netdev@...r.kernel.org Subject: Re: [PATCH net 1/2] mpls: Fix mpls_gso handler. On Thu, Oct 30, 2014 at 12:49:57AM -0700, Pravin B Shelar wrote: > mpls gso handler needs to pull skb after segmenting skb. > > CC: Simon Horman <simon.horman@...ronome.com> > Signed-off-by: Pravin B Shelar <pshelar@...ira.com> Apologies for messing that up, your change does seem to match the comment above it. So, assuming that this has been tested: Acked-by: Simon Horman <simon.horman@...ronome.com> > --- > net/mpls/mpls_gso.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/net/mpls/mpls_gso.c b/net/mpls/mpls_gso.c > index f0f5309..e3545f2 100644 > --- a/net/mpls/mpls_gso.c > +++ b/net/mpls/mpls_gso.c > @@ -59,8 +59,7 @@ static struct sk_buff *mpls_gso_segment(struct sk_buff *skb, > * above pulled. It will be re-pushed after returning > * skb_mac_gso_segment(), an indirect caller of this function. > */ > - __skb_push(skb, skb->data - skb_mac_header(skb)); > - > + __skb_pull(skb, skb->data - skb_mac_header(skb)); > out: > return segs; > } > -- > 1.7.1 > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists