lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 3 Nov 2014 06:01:46 +0800 From: Herbert Xu <herbert@...dor.apana.org.au> To: Linus Lüssing <linus.luessing@....de> Cc: netdev@...r.kernel.org, bridge@...ts.linux-foundation.org, Stephen Hemminger <stephen@...workplumber.org>, "David S. Miller" <davem@...emloft.net>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] bridge: fix netfilter/NF_BR_LOCAL_OUT for own, locally generated queries On Mon, Sep 22, 2014 at 01:32:44AM +0200, Linus Lüssing wrote: > Ebtables on the OUTPUT chain (NF_BR_LOCAL_OUT) would not work as expected > for both locally generated IGMP and MLD queries. The IP header specific > filter options are off by 14 Bytes for netfilter (actual output on > interfaces is fine). > > NF_HOOK() expects the skb->data to point to the IP header, not the > ethernet one (while dev_queue_xmit() does not). Luckily there is an > br_dev_queue_push_xmit() helper function already - let's just use that. > > Introduced by eb1d16414339a6e113d89e2cca2556005d7ce919 > ("bridge: Add core IGMP snooping support") > > Ebtables example: > > $ ebtables -I OUTPUT -p IPv6 -o eth1 --logical-out br0 \ > --log --log-level 6 --log-ip6 --log-prefix="~EBT: " -j DROP > > before (broken): > > ~EBT: IN= OUT=eth1 MAC source = 02:04:64:a4:39:c2 \ > MAC dest = 33:33:00:00:00:01 proto = 0x86dd IPv6 \ > SRC=64a4:39c2:86dd:6000:0000:0020:0001:fe80 IPv6 \ > DST=0000:0000:0000:0004:64ff:fea4:39c2:ff02, \ > IPv6 priority=0x3, Next Header=2 > > after (working): > > ~EBT: IN= OUT=eth1 MAC source = 02:04:64:a4:39:c2 \ > MAC dest = 33:33:00:00:00:01 proto = 0x86dd IPv6 \ > SRC=fe80:0000:0000:0000:0004:64ff:fea4:39c2 IPv6 \ > DST=ff02:0000:0000:0000:0000:0000:0000:0001, \ > IPv6 priority=0x0, Next Header=0 > > Signed-off-by: Linus Lüssing <linus.luessing@....de> Acked-by: Herbert Xu <herbert@...dor.apana.org.au> Cheers, -- Email: Herbert Xu <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists