[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1415036355.17743.22.camel@perches.com>
Date: Mon, 03 Nov 2014 09:39:15 -0800
From: Joe Perches <joe@...ches.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@...com>,
netdev@...r.kernel.org,
Kweh Hock Leong <hock.leong.kweh@...el.com>,
"David S . Miller" <davem@...emloft.net>,
Vince Bridgers <vbridgers2013@...il.com>
Subject: Re: [PATCH] stmmac: remove custom implementation of print_hex_dump()
On Mon, 2014-11-03 at 19:28 +0200, Andy Shevchenko wrote:
> There is a kernel helper to dump buffers in a hexdecimal format. This patch
> substitutes the open coded function by calling that helper.
[]
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
[]
> @@ -191,14 +191,8 @@ static void stmmac_clk_csr_set(struct stmmac_priv *priv)
>
> static void print_pkt(unsigned char *buf, int len)
> {
> - int j;
> - pr_debug("len = %d byte, buf addr: 0x%p", len, buf);
> - for (j = 0; j < len; j++) {
> - if ((j % 16) == 0)
> - pr_debug("\n %03x:", j);
> - pr_debug(" %02x", buf[j]);
> - }
> - pr_debug("\n");
> + pr_debug("len = %d byte, buf addr: 0x%p\n", len, buf);
> + print_hex_dump(KERN_DEBUG, " ", DUMP_PREFIX_OFFSET, 16, 1, buf, len, 0);
Prefix should be ""
Please use true/false for the last argument
Another (better?) option would be to use:
print_hex_dump_bytes("", DUMP_PREFIX_OFFSET, buf, len);
so that it can be dynamically controlled like
the pr_debug statements.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists