netdev - Re: macvtap: Fix csum_start when VLAN tags are present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141103.145242.1681559211164468290.davem@davemloft.net>
Date:	Mon, 03 Nov 2014 14:52:42 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	netdev@...r.kernel.org
Subject: Re: macvtap: Fix csum_start when VLAN tags are present

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Mon, 3 Nov 2014 14:01:25 +0800

> When VLAN is in use in macvtap_put_user, we end up setting
> csum_start to the wrong place.  The result is that the whoever
> ends up doing the checksum setting will corrupt the packet instead
> of writing the checksum to the expected location, usually this
> means writing the checksum with an offset of -4.
> 
> This patch fixes this by adjusting csum_start when VLAN tags are
> detected.
> 
> Fixes: f09e2249c4f5 ("macvtap: restore vlan header on user read")
> Cc: stable@...r.kernel.org
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied, thanks Herbert.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html