netdev - Re: [PATCH net] sfc: don't BUG_ON efx->max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141103.155821.1814140850277209257.davem@davemloft.net>
Date:	Mon, 03 Nov 2014 15:58:21 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ecree@...arflare.com
Cc:	netdev@...r.kernel.org, sshah@...arflare.com,
	linux-net-drivers@...arflare.com
Subject: Re: [PATCH net] sfc: don't BUG_ON efx->max_channels == 0 in probe

From: Edward Cree <ecree@...arflare.com>
Date: Mon, 3 Nov 2014 14:14:35 +0000

> efx_ef10_probe() was BUGging out if the BAR2 size was 0.  This is
>  unnecessarily violent; instead we should just fail to probe the device.
> Kept a WARN_ON as this problem indicates a broken or misconfigured NIC.
> 
> Signed-off-by: Edward Cree <ecree@...arflare.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html