netdev - Re: [PATCH net-next] net: add rbnode to struct sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20141103.163748.929657552226178600.davem@davemloft.net>
Date:	Mon, 03 Nov 2014 16:37:48 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	cwang@...pensource.com
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org, wygivan@...gle.com
Subject: Re: [PATCH net-next] net: add rbnode to struct sk_buff

From: Cong Wang <cwang@...pensource.com>
Date: Mon, 3 Nov 2014 13:34:33 -0800

> No objections, but this is hacky, rbnode is larger than ->next + ->prev,
> this means ->tstamp is always overwritten. This is why netem saves it
> to its CB. This isn't flexible.

It's the size of next+prev+tstamp.  Eric is showing exactly what is
shared with what with the struct/union layout.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html