netdev - Re: [PATCH net-next] net: add rbnode to struct sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1415054164.1005.2.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Mon, 03 Nov 2014 14:36:04 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Cong Wang <cwang@...pensource.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Yaogong Wang <wygivan@...gle.com>
Subject: Re: [PATCH net-next] net: add rbnode to struct sk_buff

On Mon, 2014-11-03 at 13:41 -0800, Cong Wang wrote:
> On Mon, Nov 3, 2014 at 1:37 PM, David Miller <davem@...emloft.net> wrote:
> > From: Cong Wang <cwang@...pensource.com>
> > Date: Mon, 3 Nov 2014 13:34:33 -0800
> >
> >> No objections, but this is hacky, rbnode is larger than ->next + ->prev,
> >> this means ->tstamp is always overwritten. This is why netem saves it
> >> to its CB. This isn't flexible.
> >
> > It's the size of next+prev+tstamp.  Eric is showing exactly what is
> > shared with what with the struct/union layout.
> 
> I knew, I meant saving tstamp is not flexible, or at least not pretty. :)

Note that TCP stack doesn't care saving tstamp for packets in out of
order queue.

Even for netem, I am not sure it is needed at all.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html