[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20141103002139.GW7996@ZenIV.linux.org.uk>
Date: Mon, 3 Nov 2014 00:21:39 +0000
From: Al Viro <viro@...IV.linux.org.uk>
To: Herbert Xu <herbert@...dor.apana.org.au>
Cc: "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Benjamin LaHaise <bcrl@...ck.org>
Subject: Re: fs: Use non-const iov in aio_read/aio_write
On Mon, Nov 03, 2014 at 12:16:34AM +0000, Al Viro wrote:
> NAK with extreme prejudice. The right way to deal with that is
> to convert the socket side of things to iov_iter. And give it a
> consistent behaviour, while we are at it (some protocols do advance
> the damn thing, so do not). There are _very_ good reasons to have those
> iovecs unchanged - if you look at the callers on the socket side, you'll
> see a bunch that has to _copy_ iovec just to avoid it being buggered.
> And you get rather suboptimal behaviour in memcpy_fromiovec() and friends,
> exactly because you have to skip through the emptied elements.
>
> IOW, no way in hell.
PS: I do have the beginning of that stuff sitting in the local queue since
April; see http://marc.info/?l=linux-xfs&m=139179304710494&w=2 for the
beginning of the story.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists