lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 04 Nov 2014 20:42:49 +0100 From: Daniel Borkmann <dborkman@...hat.com> To: Fabian Frederick <fabf@...net.be> CC: linux-kernel@...r.kernel.org, Steffen Klassert <steffen.klassert@...unet.com>, Herbert Xu <herbert@...dor.apana.org.au>, "David S. Miller" <davem@...emloft.net>, Alexey Kuznetsov <kuznet@....inr.ac.ru>, James Morris <jmorris@...ei.org>, Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>, Patrick McHardy <kaber@...sh.net>, netdev@...r.kernel.org Subject: Re: [PATCH 1/1 net-next] esp4: remove assignment in if condition On 11/04/2014 08:28 PM, Fabian Frederick wrote: > Signed-off-by: Fabian Frederick <fabf@...net.be> > --- > net/ipv4/esp4.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/net/ipv4/esp4.c b/net/ipv4/esp4.c > index 360b565..9dd66ee 100644 > --- a/net/ipv4/esp4.c > +++ b/net/ipv4/esp4.c > @@ -392,8 +392,11 @@ static int esp_input(struct xfrm_state *x, struct sk_buff *skb) > if (elen <= 0) > goto out; > > - if ((err = skb_cow_data(skb, 0, &trailer)) < 0) > + err = skb_cow_data(skb, 0, &trailer); > + If you already feel the need to change this (?), then please don't add an extra newline here ... > + if (err < 0) > goto out; > + > nfrags = err; > > assoclen = sizeof(*esph); > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists