netdev - Re: [PATCH] stmmac: fix sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20141104.165958.657451417783601838.davem@davemloft.net>
Date:	Tue, 04 Nov 2014 16:59:58 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	peppe.cavallaro@...com
Cc:	andriy.shevchenko@...ux.intel.com, netdev@...r.kernel.org,
	hock.leong.kweh@...el.com, vbridgers2013@...il.com
Subject: Re: [PATCH] stmmac: fix sparse warnings

From: Giuseppe CAVALLARO <peppe.cavallaro@...com>
Date: Tue, 4 Nov 2014 17:35:17 +0100

> On 11/3/2014 6:28 PM, Andy Shevchenko wrote:
>> This patch fixes the following sparse warnings.
>>
>> drivers/net/ethernet/stmicro/stmmac/enh_desc.c:381:30: warning: symbol
>> 'enh_desc_ops' was not declared. Should it be static?
>> drivers/net/ethernet/stmicro/stmmac/norm_desc.c:253:30: warning:
>> symbol 'ndesc_ops' was not declared. Should it be static?
>> drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c:141:33: warning:
>> symbol 'stmmac_ptp' was not declared. Should it be static?
>>
>> There is no functional change.
> 
> Hello Andy
> 
> I have never seen this kind of warnings.

Are you running the 'sparse' checker with all options enabled?
This is one of the most fundamental warnings it spits out.

> I prefer to not include the
> stmmac.h in enh_desc.c and norm_desc.c but eventually to move the
> following from stmmac.h to common.h:
>   extern const struct stmmac_desc_ops enh_desc_ops;
>   extern const struct stmmac_desc_ops ndesc_ops;
> what do you think?

You two sort this out and submit a new patch, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html