netdev - Re: [Patch net-next v2] neigh: remove dynamic neigh table registration support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20141104.170251.950859328398615616.davem@davemloft.net>
Date:	Tue, 04 Nov 2014 17:02:51 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	xiyou.wangcong@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [Patch net-next v2] neigh: remove dynamic neigh table
 registration support

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Mon,  3 Nov 2014 10:14:14 -0800

> Currently there are only three neigh tables in the whole kernel:
> arp table, ndisc table and decnet neigh table. What's more,
> we don't support registering multiple tables per family.
> Therefore we can just make these tables statically built-in.
> 
> Cc: David S. Miller <davem@...emloft.net>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>
> ---
> v2: remove useless #ifdef's
>     move the assignment to the end of neigh_table_init()

neigh_table_clear should definitely NULL out the slot, otherwise
we hold in there a pointer to module memory which is about to
be released.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html