netdev - RE: [PATCH] net: eth: realtek: atp: checkpatch errors and warnings corrected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1C9E71E4@AcuExch.aculab.com>
Date:	Tue, 4 Nov 2014 10:19:58 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Roberto Medina' <robertoxmed@...il.com>,
	Joe Perches <joe@...ches.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] net: eth: realtek: atp: checkpatch errors and warnings
 corrected

From: Roberto Medina
> On 11/03/2014 07:51 PM, Joe Perches wrote:
> >
> > Some ancient drivers could be regarded as neolithic
> > curiosities that never need updating.  This may be one.
> >
> > But if you really want to change it, could you please
> > make sure that objdiff shows no changes?
> >
> 
> I see some changes with objdiff, maybe this is caused by the include
> file that I changed to linux/io.h instead of asm/io.h
> 
> ---
> /home/vov/Git/linux-next/.tmp_objdiff/a641d0e/drivers/net/ethernet/realtek/atp.dis
> 2014-11-03 19:59:18.723954900 +0100
> +++
> /home/vov/Git/linux-next/.tmp_objdiff/5f19b70/drivers/net/ethernet/realtek/atp.dis
> 2014-11-03 20:00:34.133954217 +0100
> @@ -1753,9 +1753,8 @@
>   	...
>   :	e3 0a                	jrcxz  4c4 <__gcov_.atp_probe1+0x14>
>   :	00 00                	add    %al,(%rax)
> -:	e2 e2                	loop   4a0 <__gcov_.atp_init+0x20>
> -:	9c                   	pushfq
> -:	9a                   	(bad)
> +:	4b b4 98             	rex.WXB mov $0x98,%r12b
> +:	ac                   	lods   %ds:(%rsi),%al
>   :	67 2f                	addr32 (bad)
>   :	e4 e3                	in     $0xe3,%al
>   :	00 00                	add    %al,(%rax)

That code (and all the ones below) are gibberish, neither the old or new
sequences make any sense.

Almost as though you used the wrong instruction set!

	David



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html