netdev - Re: [PATCH V1 net-next 5/5] net/mlx4_core: Add retrieval of CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1415119714.1005.3.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Tue, 04 Nov 2014 08:48:34 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Or Gerlitz <ogerlitz@...lanox.com>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Matan Barak <matanb@...lanox.com>,
	Amir Vadai <amirv@...lanox.com>,
	Saeed Mahameed <saeedm@...lanox.com>,
	Shani Michaeli <shanim@...lanox.com>,
	Ido Shamay <idos@...lanox.com>
Subject: Re: [PATCH V1 net-next 5/5] net/mlx4_core: Add retrieval of
 CONFIG_DEV parameters

On Sun, 2014-11-02 at 16:26 +0200, Or Gerlitz wrote:
> From: Matan Barak <matanb@...lanox.com>
> 
> Add code to issue CONFIG_DEV "get" firmware command.
> 
> This command is used in order to obtain certain parameters used for
> supporting various RX checksumming options and vxlan UDP port.
> 
> The GET operation is allowed for VFs too.
> 
> Signed-off-by: Matan Barak <matanb@...lanox.com>
> Signed-off-by: Shani Michaeli <shanim@...lanox.com>
> Signed-off-by: Or Gerlitz <ogerlitz@...lanox.com>
> ---
>  drivers/net/ethernet/mellanox/mlx4/cmd.c           |    4 +-
>  drivers/net/ethernet/mellanox/mlx4/fw.c            |   88 +++++++++++++++++++-
>  drivers/net/ethernet/mellanox/mlx4/mlx4.h          |    5 +
>  .../net/ethernet/mellanox/mlx4/resource_tracker.c  |   17 ++++
>  include/linux/mlx4/cmd.h                           |   29 +++++++
>  include/linux/mlx4/device.h                        |    3 +-
>  6 files changed, 139 insertions(+), 7 deletions(-)

This added following warnings :

  CC      drivers/net/ethernet/mellanox/mlx4/fw.o
drivers/net/ethernet/mellanox/mlx4/fw.c: In function 'mlx4_config_dev_retrieval':
drivers/net/ethernet/mellanox/mlx4/fw.c:1944:12: warning: 'config_dev.rx_checksum_val' may be used uninitialized in this function [-Wmaybe-uninitialized]
In file included from include/linux/swab.h:4:0,
                 from include/uapi/linux/byteorder/little_endian.h:12,
                 from include/linux/byteorder/little_endian.h:4,
                 from ./arch/x86/include/uapi/asm/byteorder.h:4,
                 from include/asm-generic/bitops/le.h:5,
                 from ./arch/x86/include/asm/bitops.h:504,
                 from include/linux/bitops.h:33,
                 from include/linux/kernel.h:10,
                 from include/linux/skbuff.h:17,
                 from include/linux/if_ether.h:23,
                 from include/linux/etherdevice.h:25,
                 from drivers/net/ethernet/mellanox/mlx4/fw.c:35:
include/uapi/linux/swab.h:53:93: warning: 'config_dev.vxlan_udp_dport' may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/net/ethernet/mellanox/mlx4/fw.c:1922:25: note: 'config_dev.vxlan_udp_dport' was declared here


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html