lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 05 Nov 2014 14:54:43 -0500 (EST) From: David Miller <davem@...emloft.net> To: hariprasad@...lsio.com Cc: netdev@...r.kernel.org, linux-rdma@...r.kernel.org, linux-scsi@...r.kernel.org, roland@...estorage.com, JBottomley@...allels.com, hch@...radead.org, swise@...ngridcomputing.com, leedom@...lsio.com, praveenm@...lsio.com, anish@...lsio.com, nirranjan@...lsio.com, kumaras@...lsio.com Subject: Re: [PATCHv2 net-next 0/3] RDMA/cxgb4,cxgb4vf,cxgb4i,csiostor: Cleanup macros From: Hariprasad Shenai <hariprasad@...lsio.com> Date: Tue, 4 Nov 2014 08:20:54 +0530 > It's not really the "hardware" which generates these hardware constant symbolic > macros/register defines of course, it's scripts developed by the hardware team. > Various patches have ended up changing the style of the symbolic macros/register > defines and some of them used the macros/register defines that matches the > output of the script from the hardware team. We've told you that we don't care what format your internal whatever uses for these macros. We have standards, tastes, and desires and reasons for naming macros in a certain way in upstream kernel code. I consider it flat out unacceptable to use macros with one letter prefixes like "S_". You simply should not do this. Why? Because you are polluting the global name space, that's why. You should only define macros with very-likely-to-be-unique prefixes otherwise you and some arch/* header file are going to define the same thing. This is not just theory, it has happened in the past. I'm not applying this series, fixup your macros properly. And to repeat, complaints about how your internal tools generate things will fall on deaf ears. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists