netdev - Re: [PATCH v2 net] tcp: zero retrans_stamp if all retrans were acked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141105.170044.838421908925675417.davem@davemloft.net>
Date:	Wed, 05 Nov 2014 17:00:44 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ncardwell@...gle.com
Cc:	mleitner@...hat.com, netdev@...r.kernel.org, ycheng@...gle.com,
	edumazet@...gle.com
Subject: Re: [PATCH v2 net] tcp: zero retrans_stamp if all retrans were
 acked

From: Neal Cardwell <ncardwell@...gle.com>
Date: Tue, 4 Nov 2014 15:10:31 -0500

> On Tue, Nov 4, 2014 at 2:15 PM, Marcelo Ricardo Leitner
> <mleitner@...hat.com> wrote:
> ...
>> Therefore, now we clear retrans_stamp as soon as all data during the
>> loss window is fully acked.
>>
>> Reported-by: Ueki Kohei
>> Cc: Neal Cardwell <ncardwell@...gle.com>
>> Cc: Yuchung Cheng <ycheng@...gle.com>
>> Signed-off-by: Marcelo Ricardo Leitner <mleitner@...hat.com>
>> ---
>>
>> Notes:
>>     v1->v2: fixed compilation issue noticed by Neal
>>
>>  net/ipv4/tcp_input.c | 60 +++++++++++++++++++++++++++-------------------------
>>  1 file changed, 31 insertions(+), 29 deletions(-)
> 
> Acked-by: Neal Cardwell <ncardwell@...gle.com>
> Tested-by: Neal Cardwell <ncardwell@...gle.com>
> 
> Code looks fine, and it passes Yuchung's packetdrill test case for this.
> 
> Thanks for finding and fixing this, Marcelo.

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html