netdev - Re: Convert net_msg_warn, NETDEBUG, & LIMIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20141105.171623.1142237070388305283.davem@davemloft.net>
Date:	Wed, 05 Nov 2014 17:16:23 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	realty@...ches.com
Cc:	netdev@...r.kernel.org
Subject: Re: Convert net_msg_warn, NETDEBUG, & LIMIT_NETDEBUG?

From: Joe Perches <realty@...ches.com>
Date: Tue, 04 Nov 2014 12:46:40 -0800

> net_msg_warn is a sysctl used to control the printk
> of a bundle of mostly ipv4/ipv6 logging messages.
> 
> Does anyone use it?
  ...
> Should those KERN_DEBUG uses be converted to
> net_dbg_ratelimited so that these uses could be
> controlled via dynamic_debug instead of the
> net_msg_warn sysctl?
  ...

I will respond to this by saying that, generally speaking, I'd
rather we move away from local debugging facility and controls
and towards the generic ones.

Definitely kill the allocation failure debug stuff, that's obviously
superfluous and bogus.

It may be the case that we're stuck with the net_msg_warn sysctl
for the stuff that isn't obviously extraneous and removable like
the allocation failure cases.

Why don't we work on these one at a time and see what's left after
all the adjustments/deletions?

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html