lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAGm1_ktWK5ai85PZJTkq8Q1mAFH6JZ5XM1mDOHO3K_N2iGNLWg@mail.gmail.com> Date: Thu, 6 Nov 2014 17:25:13 +0100 From: Yegor Yefremov <yegorslists@...glemail.com> To: netdev <netdev@...r.kernel.org> Cc: "N, Mugunthan V" <mugunthanvnm@...com>, mpa@...gutronix.de, lsorense@...lub.uwaterloo.ca, Daniel Mack <zonque@...il.com> Subject: am335x: cpsw: phy ignores max-speed setting I' m trying to override max-speed setting for both CPSW connected PHYs. This is my DTS section for configuring CPSW: &mac { pinctrl-names = "default", "sleep"; pinctrl-0 = <&cpsw_default>; pinctrl-1 = <&cpsw_sleep>; dual_emac = <1>; status = "okay"; }; &davinci_mdio { pinctrl-names = "default", "sleep"; pinctrl-0 = <&davinci_mdio_default>; pinctrl-1 = <&davinci_mdio_sleep>; status = "okay"; }; &cpsw_emac0 { phy_id = <&davinci_mdio>, <0>; phy-mode = "rgmii-id"; dual_emac_res_vlan = <1>; max-speed = <100>; }; &cpsw_emac1 { phy_id = <&davinci_mdio>, <1>; phy-mode = "rgmii-id"; dual_emac_res_vlan = <2>; max-speed = <100>; }; But in drivers/net/phy/phy_device.c->of_set_phy_supported() routine I don't get through node check, i.e. node == NULL. Any idea why? static void of_set_phy_supported(struct phy_device *phydev) { struct device_node *node = phydev->dev.of_node; u32 max_speed; if (!IS_ENABLED(CONFIG_OF_MDIO)) return; if (!node) return; if (!of_property_read_u32(node, "max-speed", &max_speed)) { /* The default values for phydev->supported are provided by the PHY * driver "features" member, we want to reset to sane defaults fist * before supporting higher speeds. */ phydev->supported &= PHY_DEFAULT_FEATURES; switch (max_speed) { default: return; case SPEED_1000: phydev->supported |= PHY_1000BT_FEATURES; case SPEED_100: phydev->supported |= PHY_100BT_FEATURES; case SPEED_10: phydev->supported |= PHY_10BT_FEATURES; } } } Yegor -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists