lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20141106173333.GZ7996@ZenIV.linux.org.uk> Date: Thu, 6 Nov 2014 17:33:33 +0000 From: Al Viro <viro@...IV.linux.org.uk> To: Herbert Xu <herbert@...dor.apana.org.au> Cc: David Miller <davem@...emloft.net>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, bcrl@...ck.org, YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org> Subject: Re: [PATCH 3/4] macvtap: Use iovec iterators On Thu, Nov 06, 2014 at 04:28:20PM +0800, Herbert Xu wrote: > + if (copy_to_iter(&vnet_hdr, sizeof(vnet_hdr), iter)) > return -EFAULT; Again, wrong calling conventions. It returns how much has it copied. > + ret = copy_to_iter(&veth, sizeof(veth), iter); > + if (ret || !iov_iter_count(iter)) > goto done; Ditto. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists