netdev - Re: [PATCH] net: mv643xx_eth: reclaim TX skbs only when released by the HW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141106.145534.804171709065169233.davem@davemloft.net>
Date:	Thu, 06 Nov 2014 14:55:34 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	karl.beldan@...il.com
Cc:	karl.beldan@...ierawaves.com, netdev@...r.kernel.org,
	ijc@...lion.org.uk, eric.dumazet@...il.com,
	ezequiel.garcia@...e-electrons.com, sebastian.hesselbarth@...il.com
Subject: Re: [PATCH] net: mv643xx_eth: reclaim TX skbs only when released
 by the HW

From: Karl Beldan <karl.beldan@...il.com>
Date: Wed,  5 Nov 2014 15:32:59 +0100

> From: Karl Beldan <karl.beldan@...ierawaves.com>
> 
> ATM, txq_reclaim will dequeue and free an skb for each tx desc released
> by the hw that has TX_LAST_DESC set. However, in case of TSO, each
> hw desc embedding the last part of a segment has TX_LAST_DESC set,
> losing the one-to-one 'last skb frag'/'TX_LAST_DESC set' correspondance,
> which causes data corruption.
> 
> Fix this by checking TX_ENABLE_INTERRUPT instead of TX_LAST_DESC, and
> warn when trying to dequeue from an empty txq (which can be symptomatic
> of releasing skbs prematurely).
> 
> Fixes: 3ae8f4e0b98 ('net: mv643xx_eth: Implement software TSO')
> Reported-by: Slawomir Gajzner <slawomir.gajzner@...il.com>
> Reported-by: Julien D'Ascenzio <jdascenzio@...oo.fr>
> Signed-off-by: Karl Beldan <karl.beldan@...ierawaves.com>

Applied and queued up for -stable, but it seems there might still be some
bugs to resolve...
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html