netdev - Re: [PATCH 0/2 net-next] sunvnet: bug fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 06 Nov 2014 15:17:07 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	sowmini.varadhan@...cle.com
Cc:	david.stevens@...cle.com, ben@...adent.org.uk,
	netdev@...r.kernel.org
Subject: Re: [PATCH 0/2 net-next] sunvnet: bug fixes

From: Sowmini Varadhan <sowmini.varadhan@...cle.com>
Date: Thu, 6 Nov 2014 14:50:54 -0500

> This patch series has a coding-style fix and a bug fix.
> 
> The coding style fix (patch 1) is the extra indentation flagged by
> Ben Hutchings:
>   http://marc.info/?l=linux-netdev&m=141529243409594&w=2
> 
> The bugfix (patch 2) is the following: 
> when vnet_event_napi() is  called as part of napi_resume 
> (i.e., continuation of a previous NAPI read that was truncated 
> due to budget constraints), and then finds no more packets to read, 
> the code was trying to avoid an additional trip through ldc_rx 
> as an optimization. However, when this corner case happens, we would
> need to reset a number of dring state bits such as rcv_nxt carefully, 
> which quickly becomes complex and hacky.  The cleaner solution
> is to just roll back to vnet_poll, re-enable interrupts and set up
> dring state as was done in the pre-NAPI version of the driver.

Series applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html