lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20141106214940.GD44162@ubuntu-hedt> Date: Thu, 6 Nov 2014 15:49:40 -0600 From: Seth Forshee <seth.forshee@...onical.com> To: netdev@...r.kernel.org Cc: "David S. Miller" <davem@...emloft.net>, Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>, Boris Ostrovsky <boris.ostrovsky@...cle.com>, David Vrabel <david.vrabel@...rix.com>, Stefan Bader <stefan.bader@...onical.com>, Jay Vosburgh <jay.vosburgh@...onical.com>, linux-kernel@...r.kernel.org, xen-devel@...ts.xenproject.org, seth.forshee@...onical.com Subject: BUG in xennet_make_frags with paged skb data We've had several reports of hitting the following BUG_ON in xennet_make_frags with 3.2 and 3.13 kernels (I'm currently awaiting results of testing with 3.17): /* Grant backend access to each skb fragment page. */ for (i = 0; i < frags; i++) { skb_frag_t *frag = skb_shinfo(skb)->frags + i; struct page *page = skb_frag_page(frag); len = skb_frag_size(frag); offset = frag->page_offset; /* Data must not cross a page boundary. */ BUG_ON(len + offset > PAGE_SIZE<<compound_order(page)); When this happens the page in question is a "middle" page in a compound page (i.e. it's a tail page but not the last tail page), and the data is fully contained within the compound page. The data does however cross the hardware page boundary, and since compound_order evaluates to 0 for tail pages the check fails. In going over this I've been unable to determine whether the BUG_ON in xennet_make_frags is incorrect or the paged skb data is wrong. I can't find that it's documented anywhere, and the networking code itself is a bit ambiguous when it comes to compound pages. On the one hand __skb_fill_page_desc specifically handles adding tail pages as paged data, but on the other hand skb_copy_bits kmaps frag->page.p which could fail with data that extends into another page. Can anyone explain what the rules are here? My best guess based on skb_copy_bits is that paged data should never cross the hardware page boundary, but I'm not really sure how all of this works out when dealing with compound pages. Thanks, Seth -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists