netdev - Re: [PATCH net-next] net/fm10k: Avoid double setting of NETIF_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D0827E2E.5ED4E%matthew.vick@intel.com>
Date:	Fri, 7 Nov 2014 21:57:10 +0000
From:	"Vick, Matthew" <matthew.vick@...el.com>
To:	Or Gerlitz <ogerlitz@...lanox.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net/fm10k: Avoid double setting of NETIF_F_SG
 for the HW encapsulation feature mask

On 11/6/14, 1:21 AM, "Or Gerlitz" <ogerlitz@...lanox.com> wrote:

>The networking core does it for the driver during registration time.
>
>Signed-off-by: Or Gerlitz <ogerlitz@...lanox.com>
>---
> drivers/net/ethernet/intel/fm10k/fm10k_netdev.c |    5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c
>b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c
>index 8811364..2b17cd8 100644
>--- a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c
>+++ b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c
>@@ -1414,13 +1414,12 @@ struct net_device *fm10k_alloc_netdev(void)
> 	dev->vlan_features |= dev->features;
> 
> 	/* configure tunnel offloads */
>-	dev->hw_enc_features = NETIF_F_IP_CSUM |
>+	dev->hw_enc_features |= NETIF_F_IP_CSUM |
> 			       NETIF_F_TSO |
> 			       NETIF_F_TSO6 |
> 			       NETIF_F_TSO_ECN |
> 			       NETIF_F_GSO_UDP_TUNNEL |
>-			       NETIF_F_IPV6_CSUM |
>-			       NETIF_F_SG;
>+			       NETIF_F_IPV6_CSUM;
> 
> 	/* we want to leave these both on as we cannot disable VLAN tag
> 	 * insertion or stripping on the hardware since it is contained

Good catch, Or! Thank you for taking care of this!

Someone can correct me if I'm mistaken (I thought checkpatch would
complain about this, but it doesn't seem to be), but I believe the start
of the lines should match up like they are for the dev->features. Would
you like to submit a V2 with this change or would you like me to do it
(giving you credit via your Reported-by)?

Cheers,
Matthew

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html