netdev - Re: [net-next 1/9] i40e: poll firmware slower

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141107150223.00004b23@unknown>
Date:	Fri, 7 Nov 2014 15:02:23 -0800
From:	Jesse Brandeburg <jesse.brandeburg@...el.com>
To:	Or Gerlitz <gerlitz.or@...il.com>
Cc:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	David Miller <davem@...emloft.net>,
	Kamil Krawczyk <kamil.krawczyk@...el.com>,
	Linux Netdev List <netdev@...r.kernel.org>,
	<nhorman@...hat.com>, <sassmann@...hat.com>, <jogreene@...hat.com>,
	jesse.brandeburg@...el.com
Subject: Re: [net-next 1/9] i40e: poll firmware slower

On Fri, 7 Nov 2014 15:29:15 +0200
Or Gerlitz <gerlitz.or@...il.com> wrote:

> On Fri, Nov 7, 2014 at 10:57 AM, Jeff Kirsher
> <jeffrey.t.kirsher@...el.com> wrote:
> > The code was polling the firmware tail register for completion
> 
> any reason not to sleep while waiting for this completion? can the
> firmware generate an interrupt?

The code path in question is called from the drivers when they are in
a synchronous context and can sleep or be rescheduled without issue.
An async mode is possible, but not here, because the code complexity
required to change to async mode is unmaintainable (if even doable, how
do you handle an interrupt while you're in probe?).  We use async when
it is practical.

Thanks for your comments,
Jesse

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html