netdev - Re: [net-next PATCH v3 4/5] fm10k/igb/ixgbe: Replace __skb_alloc_page with dev_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1415728594.2466.173.camel@jtkirshe-mobl>
Date:	Tue, 11 Nov 2014 09:56:34 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	David Miller <davem@...emloft.net>
Cc:	alexander.h.duyck@...hat.com, netdev@...r.kernel.org,
	linux-usb@...r.kernel.org, leedom@...lsio.com,
	hariprasad@...lsio.com, donald.c.skidmore@...el.com,
	oliver@...kum.org, balbi@...com, matthew.vick@...el.com,
	mgorman@...e.de
Subject: Re: [net-next PATCH v3 4/5] fm10k/igb/ixgbe: Replace
 __skb_alloc_page with dev_alloc_page

On Tue, 2014-11-11 at 12:48 -0500, David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Date: Tue, 11 Nov 2014 09:28:24 -0800
> 
> > On Tue, 2014-11-11 at 09:26 -0800, Alexander Duyck wrote:
> >> The Intel drivers were pretty much just using the plain vanilla GFP
> >> flags
> >> in their calls to __skb_alloc_page so this change makes it so that
> >> they use
> >> dev_alloc_page which just uses GFP_ATOMIC for the gfp_flags value.
> >> 
> >> Cc: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> >> Cc: Matthew Vick <matthew.vick@...el.com>
> >> Cc: Don Skidmore <donald.c.skidmore@...el.com>
> >> Signed-off-by: Alexander Duyck <alexander.h.duyck@...hat.com>
> >> ---
> >>  drivers/net/ethernet/intel/fm10k/fm10k_main.c |    2 +-
> >>  drivers/net/ethernet/intel/igb/igb_main.c     |    2 +-
> >>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |    3 +--
> >>  3 files changed, 3 insertions(+), 4 deletions(-)
> > 
> > Thanks Alex, I will add the patch to my queue.
> 
> I think this entire series will need to go via my tree, because the
> conversions are all required for patch #5 which removes the replaced
> interface altogether.

That is fine Dave, I think I mentioned that during Alex's v1 of the
series.  I was just letting Alex know that we were going to test his
changes, but feel free to pull the entire series.

I will give you my ACK

Acked-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)