lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 11 Nov 2014 14:47:40 +0100
From:	Petr Mladek <>
To:	Joe Perches <>
Cc:	Steven Rostedt <>,
	Corey Minyard <>,
	Alexander Viro <>,
	Pablo Neira Ayuso <>,
	Patrick McHardy <>,
	Jozsef Kadlecsik <>,
	"David S. Miller" <>,
	Alexey Kuznetsov <>,
	James Morris <>,
	Hideaki YOSHIFUJI <>,,,,,,
Subject: Re: [PATCH -next 2/2] seq_putc: Convert to return void and convert
 uses too.

On Mon 2014-11-10 10:58:57, Joe Perches wrote:
> Using the return value of seq_putc is error-prone, so
> make it return void instead.
> Reverse the logic in seq_putc to make it like seq_puts.
> Signed-off-by: Joe Perches <>

Reviewed-by: Petr Mladek <>

The changes are correct. The show() functions should return 0
even when there is an overflow. They are called by traverse()
from seq_read() that might increase the buffer size and try again.

Best Regards,
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists