lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 12 Nov 2014 14:49:49 -0500 (EST) From: David Miller <davem@...emloft.net> To: hayeswang@...ltek.com Cc: netdev@...r.kernel.org, nic_swsd@...ltek.com, linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org Subject: Re: [PATCH net-next 2/2] r8152: adjust rtl_start_rx From: Hayes Wang <hayeswang@...ltek.com> Date: Wed, 12 Nov 2014 06:29:46 +0000 > David Miller [mailto:davem@...emloft.net] >> Sent: Wednesday, November 12, 2014 1:44 PM > [...] >> What do other USB network drivers do in similar situations? > > According to the usbnet.c, it would make sure to submit the > number of min(10, RX_QLEN(dev)) rx buffers. If there are > not enough rx buffers, it schedule a tasklet for next try. > > The brief flow is as following. > 1. Call open(). > - schedule a tasklet. > 2. Tasklet is called. > if (dev->rxq.qlen < RX_QLEN(dev)) { > - submit rx buffers util the number of > min(10, RX_QLEN(dev)). If the error > occurs, break the loop. > - If the dev->rxq.qlen < RX_QLEN(dev), > schedule the tasklet. > } That sounds like a better recovery model, why don't you mimick it? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists