netdev - Re: [patch -next] amd-xgbe: fix ->rss_hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <546380A4.1030105@amd.com>
Date:	Wed, 12 Nov 2014 09:45:40 -0600
From:	Tom Lendacky <thomas.lendacky@....com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	<netdev@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [patch -next] amd-xgbe: fix ->rss_hash_type

On 11/12/2014 02:31 AM, Dan Carpenter wrote:
> There was a missing break statement so we set everything to
> PKT_HASH_TYPE_L3 even when we intended to use PKT_HASH_TYPE_L4.
>
> Fixes: 5b9dfe299e55 ('amd-xgbe: Provide support for receive side scaling')
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Acked-by: Tom Lendacky <thomas.lendacky@....com>

> ---
> This driver has a lot of Sparse endian warnings.
> http://lwn.net/Articles/205624/

I'll send a patch to address the endian warnings.

Thanks,
Tom

>
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-dev.c b/drivers/net/ethernet/amd/xgbe/xgbe-dev.c
> index 7daa2cd..55ba1dc 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-dev.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-dev.c
> @@ -1601,6 +1601,7 @@ static int xgbe_dev_read(struct xgbe_channel *channel)
>   		case RX_DESC3_L34T_IPV6_UDP:
>   			packet->rss_hash_type = PKT_HASH_TYPE_L4;
>
> +			break;
>   		default:
>   			packet->rss_hash_type = PKT_HASH_TYPE_L3;
>   		}
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html