netdev - Re: [PATCH net-next] enic: fix work done in tx napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 12 Nov 2014 22:18:50 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	f.fainelli@...il.com
Cc:	_govind@....com, netdev@...r.kernel.org, ssujith@...co.com,
	edumazet@...gle.com
Subject: Re: [PATCH net-next] enic: fix work done in tx napi_poll

From: Florian Fainelli <f.fainelli@...il.com>
Date: Wed, 12 Nov 2014 15:44:06 -0800

> On 11/12/2014 02:42 PM, Govindarajulu Varadarajan wrote:
>> With the commit d75b1ade567 ("net: less interrupt masking in NAPI") napi repoll
>> is done only when work_done == budget. In tx napi poll we always return 0.
>> So tx napi is not called again and we do not clean up the tx ring.
> 
> Good catch, I had exactly the same bug in bcmsysport.c, sounds like
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c could also need a fix.
> 
> Thanks!
> 
>> 
>> Signed-off-by: Govindarajulu Varadarajan <_govind@....com>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html