netdev - Re: [net-next PATCH 0/4] Clean up intel driver page reuse Rx code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1415897374.2454.21.camel@jtkirshe-mobl>
Date:	Thu, 13 Nov 2014 08:49:34 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Alexander Duyck <alexander.h.duyck@...hat.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [net-next PATCH 0/4] Clean up intel driver page reuse Rx code

On Thu, 2014-11-13 at 08:18 -0800, Alexander Duyck wrote:
> This patch series cleans up the page reuse and Rx path so that all of the
> fixes that have been applied to any one driver are now in place for igb,
> fm10k, and ixgbe.  It occured to me that fm10k was missing the pfmemalloc
> bits, and ixgbe was missing some logic that reduced the number of writes
> needed as well as the pfmemalloc fix.
> 
> In addition ixgbe was carrying around some mostly-dead code that was
> wrapping a call to writel.  I removed it since it masked the fact that
> ixgbe was missing the mmiowb it was supposed to have between the tail write
> and the Tx queue lock release to prevent the MMIO access from racing
> between CPUs.
> 
> Also one change made to all 3 drivers is that we now only overwrite 3 of
> the 4 DWORDs in the Rx descriptor after allocation.  The last DWORD
> contains the upper 32 bits of the header address on fetch, and the length
> and vlan on writeback.  Since we are no longer using header split we don't
> need to clear it prior to descriptor fetch as it is unused so we can save
> ourselves a cycle on 32b systems by just leaving it untouched.
> 
> ---
> 
> Alexander Duyck (4):
>       igb: Clean-up page reuse code
>       fm10k: Clean-up page reuse code
>       ixgbe: Clean-up page reuse code
>       ixgbe: Remove tail write abstraction and add missing barrier
> 
> 
>  drivers/net/ethernet/intel/fm10k/fm10k_main.c |   34 ++++---
>  drivers/net/ethernet/intel/igb/igb_main.c     |   35 +++----
>  drivers/net/ethernet/intel/ixgbe/ixgbe.h      |    5 -
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |  118 ++++++++++++-------------
>  4 files changed, 89 insertions(+), 103 deletions(-)
> 
> --

Thanks Alex, I will add your series to my queue.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)