lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 13 Nov 2014 14:44:14 +0900 From: Simon Horman <simon.horman@...ronome.com> To: John Fastabend <john.fastabend@...il.com> Cc: Jamal Hadi Salim <jhs@...atatu.com>, Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org, davem@...emloft.net, nhorman@...driver.com, andy@...yhouse.net, tgraf@...g.ch, dborkman@...hat.com, ogerlitz@...lanox.com, jesse@...ira.com, pshelar@...ira.com, azhou@...ira.com, ben@...adent.org.uk, stephen@...workplumber.org, jeffrey.t.kirsher@...el.com, vyasevic@...hat.com, xiyou.wangcong@...il.com, john.r.fastabend@...el.com, edumazet@...gle.com, sfeldma@...il.com, f.fainelli@...il.com, roopa@...ulusnetworks.com, linville@...driver.com, jasowang@...hat.com, ebiederm@...ssion.com, nicolas.dichtel@...nd.com, ryazanov.s.a@...il.com, buytenh@...tstofly.org, aviadr@...lanox.com, nbd@...nwrt.org, alexei.starovoitov@...il.com, Neil.Jerram@...aswitch.com, ronye@...lanox.com, alexander.h.duyck@...hat.com, john.ronciak@...el.com, mleitner@...hat.com, shrijeet@...il.com, gospo@...ulusnetworks.com, bcrl@...ck.org Subject: Re: [patch net-next v2 00/10] introduce rocker switch driver with hardware accelerated datapath api - phase 1: bridge fdb offload [snip] > Simon, if your feeling adventurous any feedback on the repo link > would be great. I still need to smash the commit log into something > coherent though at the moment you can see all the errors and rewrites, > etc as I made them. Hi John, here is some preliminary feedback: * I notice that the parse graph code isn't present yet. I suppose this is a difficult piece that naturally follows many other piece. None the less it is possibly the piece of most interest to me :-) * Will del and update flows require flows to already exist? And similarly, will add flow require flows with the same match to not already exist? If so, the error handling seems tricky of more than one flow is to be deleted/updated. IIRC there was some discussion of that kind of issue at the (double) round table discussion on the last day of LPC14 in Düsseldorf. * Should the .node_count value of ixgbe_table_node_l2 be 3? ixgbe_table_graph_nodes has three elements but perhaps you are intentionally excluding the last element ixgbe_table_node_nil? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists