netdev - Re: [PATCH] smsc911x: power-up phydev before doing a software reset.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 13 Nov 2014 09:27:39 +0100
From:	Javier Martinez Canillas <javier@...hile0.org>
To:	Enric Balletbo Serra <eballetbo@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	Steve Glendinning <steve.glendinning@...well.net>,
	Enrico Butera <ebutera@...il.com>
Subject: Re: [PATCH] smsc911x: power-up phydev before doing a software reset.

Hello Enric,

On Thu, Nov 13, 2014 at 8:57 AM, Enric Balletbo Serra
<eballetbo@...il.com> wrote:
>
> Yes, I'm agree. I'll send version 2 of the patch changing this. Also
> there are other places that use the mdelay family intead of
> usleep_range() and can only be invoked from process context. Maybe
> would be interesting send another patch changing this.
>

Agreed, that could be a separate patch though.

Also there is a mdelay(100) before enabling energy detect mode in
smsc911x_phy_enable_energy_detect() which I believe can be removed.

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html