lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 14 Nov 2014 09:17:39 -0800 From: Jeff Kirsher <jeffrey.t.kirsher@...el.com> To: "John W. Linville" <linville@...driver.com> Cc: netdev <netdev@...r.kernel.org>, Dave Miller <davem@...emloft.net>, Auke Kok <auke-jan.h.kok@...el.com>, Malli Chilakala <mallikarjuna.chilakala@...el.com> Subject: Re: [PATCH] e100: fix typo in MDI/MDI-X eeprom check in e100_phy_init On Fri, Nov 14, 2014 at 7:59 AM, John W. Linville <linville@...driver.com> wrote: > Although it doesn't explicitly say so, commit 60ffa478759f39a2 ("e100: > Fix MDIO/MDIO-X") appears to be intended to revert the earlier commit > 648951451e6d2d53 ("e100: fixed e100 MDI/MDI-X issues"). However, > careful examination reveals that the attempted revert actually > _inverted_ the test for eeprom_mdix_enabled. That is bound to program > a few PHYs incorrectly... > > https://bugzilla.redhat.com/show_bug.cgi?id=1156417 > > Signed-off-by: John W. Linville <linville@...driver.com> > Cc: Jeff Kirsher <jeffrey.t.kirsher@...el.com> > Cc: Auke Kok <auke-jan.h.kok@...el.com> > Cc: Malli Chilakala <mallikarjuna.chilakala@...el.com> > --- > Wow, an 8 year old bug in e100 -- woohoo!! :-) > > This was causing some serious flakiness for a large cash register > deployment in Europe. Testing with this one-line (really, > one-character) patch seems to have resolved the issue. > > drivers/net/ethernet/intel/e100.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Weird, I did not get this mail. Anyway, thanks John, I have added your patch to my queue. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists