lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 14 Nov 2014 13:38:29 -0500 (EST) From: David Miller <davem@...emloft.net> To: hannes@...essinduktion.org Cc: eric.dumazet@...il.com, netdev@...r.kernel.org, ogerlitz@...lanox.com, pshelar@...ira.com, jesse@...ira.com, jay.vosburgh@...onical.com, discuss@...nvswitch.org Subject: Re: [PATCH net-next] fast_hash: clobber registers correctly for inline function use From: Hannes Frederic Sowa <hannes@...essinduktion.org> Date: Fri, 14 Nov 2014 16:46:18 +0100 > I would still like to see the current proposed fix getting applied and > we can do this on-top. The inline call after this patch reassembles a > direct function call, so besides the long list of clobbers, it should > still be pretty fast. I would rather revert the change entirely until it is implemented properly. Also, I am strongly of the opinion that this is a mis-use of the alternative call interface. It was never intended to be used for things that can make real function calls. You can add a million clobbers, or a trampoline, it's still using a facility in a manner for which it was not designed. This means a new interface with a new name and with capabilities explicitly supporting this case are in order. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists