lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 14 Nov 2014 14:23:25 -0800 From: Florian Fainelli <f.fainelli@...il.com> To: "Martin K. Petersen" <martin.petersen@...cle.com>, netdev@...r.kernel.org CC: linux.nics@...el.com Subject: Re: [PATCH] ixgbe: Look up MAC address in Open Firmware On 11/14/2014 11:16 AM, Martin K. Petersen wrote: [snip] > +#ifdef CONFIG_OF > +/** > + * ixgbe_of_mac_addr - Look up MAC address in Open Firmware > + * @adapter: Pointer to adapter struct > + */ > +static void ixgbe_of_mac_addr(struct ixgbe_adapter *adapter) > +{ > + struct device_node *dp = pci_device_to_OF_node(adapter->pdev); > + struct ixgbe_hw *hw = &adapter->hw; > + const unsigned char *addr; > + int len; > + > + addr = of_get_property(dp, "local-mac-address", &len); > + if (addr && len == 6) { > + e_dev_info("Using OpenPROM MAC address\n"); > + memcpy(hw->mac.perm_addr, addr, 6); > + } Cannot you use of_get_mac_address() here which does iterate through all the OF standard ways to specify a MAC address: mac-address, local-mac-address and address? Benefit is that this will work for all DT-enabled platforms. > + > + if (!is_valid_ether_addr(hw->mac.perm_addr)) { > + e_dev_info("Using IDPROM MAC address\n"); > + memcpy(hw->mac.perm_addr, idprom->id_ethaddr, 6); > + } > +} > +#endif > + > /** > * ixgbe_probe - Device Initialization Routine > * @pdev: PCI device information struct > @@ -8223,6 +8253,10 @@ skip_sriov: > goto err_sw_init; > } > > +#ifdef CONFIG_OF > + ixgbe_of_mac_addr(adapter); > +#endif > + > memcpy(netdev->dev_addr, hw->mac.perm_addr, netdev->addr_len); > > if (!is_valid_ether_addr(netdev->dev_addr)) { > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists