netdev - Re: [PATCHv2 net 2/2] fm10k: Implement ndo_gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201411131629.16621.joestringer@nicira.com>
Date:	Thu, 13 Nov 2014 16:29:16 -0800
From:	Joe Stringer <joestringer@...ira.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	Shannon Nelson <shannon.nelson@...el.com>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	netdev@...r.kernel.org, matthew.vick@...el.com,
	linux.nics@...el.com, therbert@...gle.com, gerlitz.or@...il.com,
	alexander.duyck@...il.com, linux-kernel@...r.kernel.org,
	jesse@...ira.com
Subject: Re: [PATCHv2 net 2/2] fm10k: Implement ndo_gso_check()

On Thursday, November 13, 2014 16:12:39 Jeff Kirsher wrote:
> On Thu, 2014-11-13 at 15:52 -0800, Joe Stringer wrote:
> > On Thu, Nov 13, 2014 at 03:41:56PM -0800, Jeff Kirsher wrote:
> > > On Thu, 2014-11-13 at 15:36 -0800, Joe Stringer wrote:
> > > > ndo_gso_check() was recently introduced to allow NICs to report
> > 
> > the
> > 
> > > > offloading support that they have on a per-skb basis. Add an
> > > > implementation for this driver which checks for something that
> > 
> > looks
> > 
> > > > like VXLAN.
> > > > 
> > > > Signed-off-by: Joe Stringer <joestringer@...ira.com>
> > > > ---
> > > > v2: Reuse fm10k_tx_encap_offload().
> > > > ---
> > > > 
> > > >  drivers/net/ethernet/intel/fm10k/fm10k.h        |    1 +
> > > >  drivers/net/ethernet/intel/fm10k/fm10k_main.c   |    2 +-
> > > >  drivers/net/ethernet/intel/fm10k/fm10k_netdev.c |    8 ++++++++
> > > >  3 files changed, 10 insertions(+), 1 deletion(-)
> > > 
> > > Same with this one as well, thanks Joe.
> > 
> > Thanks Jeff.
> > 
> > Could you remind me, is the equivalent i40e patch on your queue or
> > were
> > we still waiting on further feedback from Shannon/Jesse?
> 
> Actually, looks like I dropped the patch due to community feedback and
> was expecting a v2.  Was I incorrect in doing so?

That's fine. There were some unresolved questions for what that version should 
look like, but I can repost to start the discussion again.

Cheers,
Joe
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html