netdev - Re: [PATCH net] ipv4: Fix incorrect error code when adding an unreachable route

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141116.141638.2195341594564232778.davem@davemloft.net>
Date:	Sun, 16 Nov 2014 14:16:38 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	pmatilai@...hat.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] ipv4: Fix incorrect error code when adding an
 unreachable route

From: Panu Matilainen <pmatilai@...hat.com>
Date: Fri, 14 Nov 2014 13:14:32 +0200

> Trying to add an unreachable route incorrectly returns -ESRCH if
> if custom FIB rules are present:
> 
> [root@...alhost ~]# ip route add 74.125.31.199 dev eth0 via 1.2.3.4
> RTNETLINK answers: Network is unreachable
> [root@...alhost ~]# ip rule add to 55.66.77.88 table 200
> [root@...alhost ~]# ip route add 74.125.31.199 dev eth0 via 1.2.3.4
> RTNETLINK answers: No such process
> [root@...alhost ~]#
> 
> Commit 83886b6b636173b206f475929e58fac75c6f2446 ("[NET]: Change "not found"
> return value for rule lookup") changed fib_rules_lookup()
> to use -ESRCH as a "not found" code internally, but for user space it
> should be translated into -ENETUNREACH. Handle the translation centrally in
> ipv4-specific fib_lookup(), leaving the DECnet case alone.
> 
> On a related note, commit b7a71b51ee37d919e4098cd961d59a883fd272d8
> ("ipv4: removed redundant conditional") removed a similar translation from
> ip_route_input_slow() prematurely AIUI.
> 
> Fixes: b7a71b51ee37 ("ipv4: removed redundant conditional")
> Signed-off-by: Panu Matilainen <pmatilai@...hat.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html