netdev - Re: [PATCH net] dcbnl : Disable software interrupts before taking dcb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141116.145126.191966834846491028.davem@davemloft.net>
Date:	Sun, 16 Nov 2014 14:51:26 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	anish@...lsio.com
Cc:	netdev@...r.kernel.org, john.fastabend@...il.com,
	neerav.parikh@...el.com
Subject: Re: [PATCH net] dcbnl : Disable software interrupts before taking
 dcb_lock

From: Anish Bhatt <anish@...lsio.com>
Date: Fri, 14 Nov 2014 16:38:31 -0800

> Solves possible lockup issues that can be seen from firmware DCB agents calling
> into the DCB app api.
> 
> DCB firmware event queues can be tied in with NAPI so that dcb events are
> generated in softIRQ context. This can results in calls to dcb_*app()
> functions which try to take the dcb_lock.
> 
> If the the event triggers while we also have the dcb_lock because lldpad or
> some other agent happened to be issuing a  get/set command we could see a cpu
> lockup.
> 
> This code was not originally written with firmware agents in mind, hence
> grabbing dcb_lock from softIRQ context was not considered.
> 
> Signed-off-by: Anish Bhatt <anish@...lsio.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html