netdev - Re: Question about Patch Submissions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHA+R7P-G4P-AzTM248FqNEm=dcuQOB_fwdM0Us3gsQgSeY0UQ@mail.gmail.com>
Date:	Tue, 18 Nov 2014 12:21:25 -0800
From:	Cong Wang <cwang@...pensource.com>
To:	rapier <rapier@....edu>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: Question about Patch Submissions

On Tue, Nov 18, 2014 at 11:13 AM, rapier <rapier@....edu> wrote:
> I've read the documentation I've been able to find on the patch submission
> process. I was hoping to clarify one thing though. When submitting a patch
> that spans multiple files and functions is it better to break the submission
> down by function or by file?
>

It depends on what you change, if your patch is trivial, say just cleaning up
whitespaces, or a big single patch doesn't harm review, it is okay not
to split it.
Otherwise, probably you need to split it logically, each of which needs to at
least compile.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html