netdev - Re: [PATCH v2 net-next] icmp: Remove some spurious dropped packet profile hits from the ICMP path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141118.155609.1055967220928366239.davem@davemloft.net>
Date:	Tue, 18 Nov 2014 15:56:09 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	raj@...dy.usa.hp.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next] icmp: Remove some spurious dropped packet
 profile hits from the ICMP path

From: raj@...dy.usa.hp.com (Rick Jones)
Date: Mon, 17 Nov 2014 14:04:29 -0800 (PST)

> From: Rick Jones <rick.jones2@...com>
> 
> If icmp_rcv() has successfully processed the incoming ICMP datagram, we
> should use consume_skb() rather than kfree_skb() because a hit on the likes
> of perf -e skb:kfree_skb is not called-for.
> 
> Signed-off-by: Rick Jones <rick.jones2@...com>

This looks better, applied, thanks Rick.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html