lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 18 Nov 2014 11:53:28 -0800 From: Cong Wang <cwang@...pensource.com> To: Jason Wang <jasowang@...hat.com> Cc: David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Michael S. Tsirkin" <mst@...hat.com> Subject: Re: [PATCH net-next] tun: return NET_XMIT_DROP for dropped packets On Mon, Nov 17, 2014 at 9:20 PM, Jason Wang <jasowang@...hat.com> wrote: > After commit 5d097109257c03a71845729f8db6b5770c4bbedc > ("tun: only queue packets on device"), NETDEV_TX_OK was returned for > dropped packets. This will confuse pktgen since dropped packets were > counted as sent ones. > > Fixing this by returning NET_XMIT_DROP to let pktgen count it as error > packet. pktgen is suspicious, it sends out packets directly without going through qdisc, so it should not care about NET_XMIT_* qdisc error code? Looks like NETDEV_TX_OK doesn't have to mean TX is successful, the comment says driver takes care of the packet, can be either dropped or sent out. We might need a new code to distinguish success or failure. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists