netdev - Re: [PATCH net-next] tun: return NET_XMIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHA+R7MfRHGbahL5ah24_W-f6c5WTTqANBaWTtdMDAyhvprZKw@mail.gmail.com>
Date:	Wed, 19 Nov 2014 11:53:22 -0800
From:	Cong Wang <cwang@...pensource.com>
To:	David Miller <davem@...emloft.net>
Cc:	Jason Wang <jasowang@...hat.com>, netdev <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Michael S. Tsirkin" <mst@...hat.com>
Subject: Re: [PATCH net-next] tun: return NET_XMIT_DROP for dropped packets

On Wed, Nov 19, 2014 at 11:46 AM, David Miller <davem@...emloft.net> wrote:
>
> Often the issue with TX return values is lack of clear documentation
> and use cases.
>

NET_XMIT_* are marked as qdisc ->enqueue() return codes
in include/linux/netdevice.h, and are indeed used mostly by
qdisc:

$ git grep NET_XMIT_ -- net/sched/ | wc -l
88
$ git grep NET_XMIT_ -- drivers/net/ | wc -l
15

It is a mess. Not to mention we have __NET_XMIT_ code too.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html