netdev - Re: [net-next 12/15] i40evf: make checkpatch happy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 19 Nov 2014 01:55:08 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Joe Perches <joe@...ches.com>
Cc:	davem@...emloft.net, Mitch Williams <mitch.a.williams@...el.com>,
	netdev@...r.kernel.org, nhorman@...hat.com, sassmann@...hat.com,
	jogreene@...hat.com
Subject: Re: [net-next 12/15] i40evf: make checkpatch happy

On Tue, 2014-11-18 at 20:59 -0800, Joe Perches wrote:
> On Tue, 2014-11-18 at 20:10 -0800, Jeff Kirsher wrote:
> > This patch is the result of running checkpatch on the i40evf driver with
> > the --strict option. The vast majority of changes are adding/removing
> > blank lines, aligning function parameters, and correcting over-long
> > lines.
> 
> Hey Mitch, Jeff:
> 
> > diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
> []
> > @@ -1265,8 +1269,8 @@ int i40evf_init_interrupt_scheme(struct i40evf_adapter *adapter)
> >  	}
> >  
> >  	dev_info(&adapter->pdev->dev, "Multiqueue %s: Queue pair count = %u",
> > -		(adapter->num_active_queues > 1) ? "Enabled" :
> > -		"Disabled", adapter->num_active_queues);
> > +		 (adapter->num_active_queues > 1) ? "Enabled" : "Disabled",
> > +		 adapter->num_active_queues);
> 
> You could add a newline to that format one day.
> 
> > diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c b/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c
> []
> > @@ -711,7 +712,6 @@ void i40evf_virtchnl_completion(struct i40evf_adapter *adapter,
> >  				"%s: Unknown event %d from pf\n",
> >  				__func__, vpe->event);
> >  			break;
> > -
> >  		}
> >  		return;
> >  	}
> > @@ -776,7 +776,7 @@ void i40evf_virtchnl_completion(struct i40evf_adapter *adapter,
> >  		break;
> >  	default:
> >  		dev_warn(&adapter->pdev->dev, "%s: Received unexpected message %d from PF\n",
> > -			__func__, v_opcode);
> > +			 __func__, v_opcode);
> >  		break;
> >  	} /* switch v_opcode */
> >  	adapter->current_op = I40E_VIRTCHNL_OP_UNKNOWN;
> 
> And be consistent with PF vs pf usage too.

Thanks for noticing, I had not caught that there was inconsistent use.
I try to catch acronyms that are not capitalized, and after looking
through the code, I see that there is inconsistent use of VF vs vf as
well.  I am putting together a patch now that will make the use of both
acronyms consistent throughout our code.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)