lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Nov 2014 20:57:21 -0500 (EST) From: David Miller <davem@...emloft.net> To: therbert@...gle.com Cc: _govind@....com, netdev@...r.kernel.org Subject: Re: [PATCH net-next] net: use skb_get_hash_raw instead of skb_get_hash in set_rps_cpu From: Tom Herbert <therbert@...gle.com> Date: Wed, 19 Nov 2014 16:51:40 -0800 > On Wed, Nov 19, 2014 at 4:16 PM, David Miller <davem@...emloft.net> wrote: >> From: Govindarajulu Varadarajan <_govind@....com> >> Date: Wed, 19 Nov 2014 15:30:44 +0530 >> >>> In set_rps_cpu, we call skb_get_hash to get the hash of skb. The caller >>> get_rps_cpu has already determined the hash of skb by calling skb_get_hash. >>> >>> Since get_rps_cpu is the only caller of set_rps_cpu, we can use skb_get_hash_raw >>> >>> Signed-off-by: Govindarajulu Varadarajan <_govind@....com> >> >> Tom, please review. And if you agree with this change, you'll need to >> be spinning your flow_id change relative to this I guess since it overlaps. >> > We should probably pass hash as an argument in set_rps_cpu. It's only > called from once place and the rflow is specifically chosen based on > hash computed by caller-- don't want any ambiguity there. Yep, that sounds a lot less error prone. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists