netdev - Re: [net-next PATCH v2] ixgbe: Remove IXGBE_FLAG_IN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1416442182.2281.2.camel@jtkirshe-mobl>
Date:	Wed, 19 Nov 2014 16:09:42 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Alexander Duyck <alexander.h.duyck@...hat.com>
Cc:	netdev@...r.kernel.org, donald.c.skidmore@...el.com
Subject: Re: [net-next PATCH v2] ixgbe: Remove IXGBE_FLAG_IN_NETPOLL since
 it doesn't do anything

On Wed, 2014-11-19 at 15:28 -0800, Alexander Duyck wrote:
> This patch removes some dead code from the cleanup path for ixgbe.
> 
> Setting and clearing the flag doesn't do anything since all we are
> doing is
> setting the flag, scheduling napi, clearing the flag and then letting
> netpoll do the polling cleanup.  As such it doesn't make much sense to
> have
> it there.
> 
> This patch also removes one minor white-space error.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...hat.com>
> ---
> 
> v2: Fixed an unused variable warning for adapter in ixgbe_rx_skb
> 
>  drivers/net/ethernet/intel/ixgbe/ixgbe.h      |    1 -
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |   18
> ++++--------------
>  2 files changed, 4 insertions(+), 15 deletions(-)

Thanks Alex, I will add your patch to my queue.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)