netdev - Re: mlx4: don't duplicate kvfree()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 20 Nov 2014 10:38:10 +0200
From:	Amir Vadai <amirv@...lanox.com>
To:	Al Viro <viro@...iv.linux.org.uk>
Cc:	Amir Vadai <amirv@...lanox.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>
Subject: Re: mlx4: don't duplicate kvfree()

On Thu, Nov 20, 2014 at 10:15 AM, Al Viro <viro@...iv.linux.org.uk> wrote:
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
> ---
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/mr.c b/drivers/net/ethernet/mellanox/mlx4/mr.c
> index 193a6ad..d6f5496 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/mr.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/mr.c
> @@ -130,10 +130,7 @@ static int mlx4_buddy_init(struct mlx4_buddy *buddy, int max_order)
>
>  err_out_free:
>         for (i = 0; i <= buddy->max_order; ++i)
> -               if (buddy->bits[i] && is_vmalloc_addr(buddy->bits[i]))
> -                       vfree(buddy->bits[i]);
> -               else
> -                       kfree(buddy->bits[i]);
> +               kvfree(buddy->bits[i]);
>
>  err_out:
>         kfree(buddy->bits);
> @@ -147,10 +144,7 @@ static void mlx4_buddy_cleanup(struct mlx4_buddy *buddy)
>         int i;
>
>         for (i = 0; i <= buddy->max_order; ++i)
> -               if (is_vmalloc_addr(buddy->bits[i]))
> -                       vfree(buddy->bits[i]);
> -               else
> -                       kfree(buddy->bits[i]);
> +               kvfree(buddy->bits[i]);
>
>         kfree(buddy->bits);
>         kfree(buddy->num_free);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Thanks Al

Acked-by: Amir Vadai <amirv@...lanox.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html