netdev - Re: [PATCH v2] sh_eth: Fix skb alloc size and alignment adjust rule.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20141121.150544.2240809721107766779.davem@davemloft.net>
Date:	Fri, 21 Nov 2014 15:05:44 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ykaneko0929@...il.com
Cc:	netdev@...r.kernel.org, horms@...ge.net.au, magnus.damm@...il.com,
	linux-sh@...r.kernel.org
Subject: Re: [PATCH v2] sh_eth: Fix skb alloc size and alignment adjust
 rule.

From: Yoshihiro Kaneko <ykaneko0929@...il.com>
Date: Thu, 20 Nov 2014 19:35:21 +0900

> From: Mitsuhiro Kimura <mitsuhiro.kimura.kc@...esas.com>
> 
> In the current driver, allocation size of skb does not care the alignment
> adjust after allocation.
> And also, in the current implementation, buffer alignment method by
> sh_eth_set_receive_align function has a bug that this function displace
> buffer start address forcedly when the alignment is corrected.
> In the result, tail of the skb will exceed allocated area and kernel panic
> will be occurred.
> This patch fix this issue.
> 
> Signed-off-by: Mitsuhiro Kimura <mitsuhiro.kimura.kc@...esas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@...il.com>
> ---
> 
> The previous version of this patch was a part of the patch series as follows:
> [PATCH 2/3] sh_eth: Fix skb alloc size and alignment adjust rule.
> 
> This series is based on net tree.
> 
> v2 [Yoshihiro Kaneko]
> * Update as suggested by Sergei Shtylyov
>   - Fixed the coding style
>   - Corrected the comment
>   - Removed {SH2_SH3|SH4}_SKB_RX_ALIGN

Please compile test your changes on 64-bit platforms:

drivers/net/ethernet/renesas/sh_eth.c: In function ‘sh_eth_set_receive_align’:
drivers/net/ethernet/renesas/sh_eth.c:922:16: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]